fix: network/resource-manager/Microsoft.Network by nschonni · Pull Request #4648 · Azure/azure-rest-api-specs

nschonni · 2018-12-01T03:32:14Z

Remove nextHopType as required because it is not a property. This build will likely fail because of other existing errors in the swagger file for duplicate paths
May be better handled by https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/readme.md#suppression but I'm not sure

openapi-portal-comment · 2018-12-01T03:32:15Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

azuresdkci · 2018-12-01T03:33:12Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-01T03:37:11Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

AutorestCI · 2018-12-01T03:37:54Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

AutorestCI · 2018-12-01T03:52:03Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

AutorestCI · 2018-12-01T05:18:08Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

AutorestCI · 2018-12-01T06:28:45Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

AutorestCI · 2018-12-01T06:42:40Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8ef5239e175616837a94888b8c1d64bcc166fd0b
  stderr: 'fatal: reference is not a tree: 8ef5239e175616837a94888b8c1d64bcc166fd0b'

nschonni · 2018-12-04T01:58:14Z

May be better handled by https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/readme.md#suppression but I'm not sure

MikhailTryakhov · 2018-12-04T22:35:08Z

@nschonni please apply your fixes to our montly branch to the latest api version 2018-11-01

nschonni · 2018-12-05T02:32:46Z

@MikhailTryakhov I've repointed this to the December branch. I'm assuming that will get merged back to master after the release. I'm also not sure this is the right fix , or if this should be a Suppression instead.

nschonni · 2018-12-14T03:28:28Z

Closing since i'm not sure if the removal or suppression is the correct fix

Remove nextHopType as required becuase it is not a property

nschonni · 2018-12-15T00:06:33Z

@number213 I'm not sure about fixing the duplicate endpoints, since one has a different path with /reset at the end #4518 (comment)

anton-evseev · 2018-12-17T11:33:14Z

@nschonni you're right, I pointer to the wrong path. The error is in those two:

/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{connectionSharedKeyName}/sharedkey
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/sharedkey

Even though they have different naming for the last parameter, they are essentialy one path.

Let's fix this by mirroring newer API versions (https://github.com/Azure/azure-rest-api-specs/blob/december-network-release/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/virtualNetworkGateway.json#L1158):

Move data under get from path with connectionSharedKeyName to path with virtualNetworkGatewayConnectionName
In that data rename connectionSharedKeyName to virtualNetworkGatewayConnectionName
Remove /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{connectionSharedKeyName}/sharedkey

nschonni · 2018-12-17T15:19:40Z

@number213 since that is a functional change to the API, it's probably better you submit it. I'm not an MS so usually non-cleanup stuff gets closed.

anton-evseev · 2018-12-18T11:03:49Z

@nschonni opened PR with fixes for those two errors: #4940

nschonni · 2018-12-18T15:25:07Z

👍 thanks @number213

nschonni requested a review from MikhailTryakhov as a code owner December 1, 2018 03:32

azuresdkci assigned jianghaolu Dec 1, 2018

azuresdkci requested a review from jianghaolu December 1, 2018 03:32

AutorestCI mentioned this pull request Dec 1, 2018

[AutoPR network/resource-manager] fix: Microsoft.Network Azure/azure-sdk-for-js#631

Closed

AutorestCI mentioned this pull request Dec 1, 2018

[AutoPR network/resource-manager] fix: Microsoft.Network Azure/azure-sdk-for-java#2677

Closed

AutorestCI mentioned this pull request Dec 1, 2018

[AutoPR network/resource-manager] fix: Microsoft.Network Azure/azure-sdk-for-node#4241

Closed

AutorestCI mentioned this pull request Dec 1, 2018

[AutoPR network/resource-manager] fix: Microsoft.Network Azure/azure-sdk-for-go#3461

Closed

jianghaolu approved these changes Dec 4, 2018

View reviewed changes

nschonni changed the base branch from master to december-network-release December 4, 2018 22:36

nschonni changed the base branch from december-network-release to master December 4, 2018 22:37

nschonni changed the base branch from master to december-network-release December 5, 2018 02:33

nschonni changed the title ~~fix: Microsoft.Network~~ fix: network/resource-manager/Microsoft.Network Dec 11, 2018

nschonni closed this Dec 14, 2018

nschonni deleted the fix-Microsoft.Network branch December 14, 2018 03:28

nschonni mentioned this pull request Dec 14, 2018

typo: Fix network/resource-manager/Microsoft.Network/network #4518

Closed

nschonni restored the fix-Microsoft.Network branch December 14, 2018 23:59

nschonni reopened this Dec 15, 2018

fix: Microsoft.Network

c65c93e

Remove nextHopType as required becuase it is not a property

AutorestCI mentioned this pull request Dec 15, 2018

[AutoPR network/resource-manager] fix: network/resource-manager/Microsoft.Network Azure/azure-sdk-for-js#846

Closed

nschonni force-pushed the fix-Microsoft.Network branch from 0d9cfa8 to c65c93e Compare December 15, 2018 00:06

This was referenced Dec 15, 2018

[AutoPR network/resource-manager] fix: network/resource-manager/Microsoft.Network Azure/azure-sdk-for-java#2795

Closed

[AutoPR network/resource-manager] fix: network/resource-manager/Microsoft.Network Azure/azure-sdk-for-node#4462

Closed

nschonni closed this Dec 18, 2018

nschonni deleted the fix-Microsoft.Network branch December 18, 2018 15:25

Conversation

nschonni commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-portal-comment bot commented Dec 1, 2018

Uh oh!

azuresdkci commented Dec 1, 2018

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

nschonni commented Dec 4, 2018

Uh oh!

MikhailTryakhov commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nschonni commented Dec 5, 2018

Uh oh!

nschonni commented Dec 14, 2018

Uh oh!

nschonni commented Dec 15, 2018

Uh oh!

anton-evseev commented Dec 17, 2018

Uh oh!

nschonni commented Dec 17, 2018

Uh oh!

anton-evseev commented Dec 18, 2018

Uh oh!

nschonni commented Dec 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nschonni commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

AutorestCI commented Dec 1, 2018 •

edited

Loading

MikhailTryakhov commented Dec 4, 2018 •

edited

Loading